Write camera path to output dir if saving to the data dir fails#3476
Merged
jb-ye merged 10 commits intonerfstudio-project:mainfrom Jan 8, 2025
krahets:patch-1
Merged
Write camera path to output dir if saving to the data dir fails#3476jb-ye merged 10 commits intonerfstudio-project:mainfrom krahets:patch-1
jb-ye merged 10 commits intonerfstudio-project:mainfrom
krahets:patch-1
Conversation
kerrj
requested changes
Oct 14, 2024
Collaborator
kerrj
left a comment
There was a problem hiding this comment.
This looks good! can you also add some sort of log statement informing users that the data dir is unwritable and that it instead wrote the path to this location?
Contributor
Author
Contributor
Author
|
Hi @kerrj, is there any comment to be addressed? |
Collaborator
|
@krahets can you also fix the linter error in core tests(Details)? |
Contributor
Author
|
@jb-ye Fixed |
kerrj
approved these changes
Jan 3, 2025
Collaborator
|
Sorry for the delay thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

If we load data from a folder without write permissions, the
Generate Commandbutton in the render panel will not respond.A simple solution is to write it to the output directory if writing to the data folder fails.