Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the rendering logic and viewer state management in the
nerfviewlibrary, alongside some refactoring and API changes. The most notable changes include the introduction of a newRenderTabStateclass to manage rendering configurations, updates to the rendering functions to accommodate this new state, and deprecation warnings for outdated APIs. Additionally, theViewerStateclass has been removed, and the library version has been incremented to0.1.0.Rendering Logic Updates:
examples/00_dummy_rendering.py,examples/01_dummy_training.py,examples/02_mesh_rendering.py,examples/03_gsplat_rendering.py, andexamples/04_gsplat_training.py) to replaceimg_whwithRenderTabStatefor dynamic width and height handling. This enables better control over preview and viewer resolutions. [1] [2] [3] [4] [5] [6]Viewer State Refactoring:
ViewerStateclass and replaced its functionality withRenderTabState. Updated references toviewer.statewithviewer.render_tab_statein the rendering logic and utility functions. [1] [2] [3]Deprecation and Backward Compatibility:
_renderer.pyfile to support older versions of therender_fnAPI. A warning is displayed if the old API is detected, encouraging users to update their implementations.New Features and Utilities:
RenderTabStateinnerfview/__init__.pyand integrated it into the viewer and rendering workflows. This class centralizes rendering-related configurations.Version Increment:
0.0.3to0.1.0innerfview/version.pyto reflect the significant changes and new features.