Make sure all health reports are deleted when a device is destroyed (#1878)

This fixes a DB constraint error

Author: joshk

lib/nerves_hub/devices.ex

@@ -1160,6 +1160,8 @@ defmodule NervesHub.Devices do
     )
   end
 
+  @spec save_device_health(health_report :: map()) ::
+          {:ok, DeviceHealth.t()} | {:error, Ecto.Changeset.t()}
   def save_device_health(device_status) do
     Multi.new()
     |> Multi.insert(:insert_health, DeviceHealth.save(device_status))

lib/nerves_hub/devices/device.ex

@@ -43,6 +43,7 @@ defmodule NervesHub.Devices.Device do
     has_many(:device_certificates, DeviceCertificate, on_delete: :delete_all)
     has_many(:device_connections, DeviceConnection, on_delete: :delete_all)
     has_many(:device_metrics, DeviceMetric, on_delete: :delete_all)
+    has_many(:device_health, DeviceHealth, on_delete: :delete_all)
 
     field(:identifier, :string)
     field(:description, :string)

test/nerves_hub/devices_test.exs

@@ -7,7 +7,9 @@ defmodule NervesHub.DevicesTest do
   alias NervesHub.Deployments
   alias NervesHub.Devices
   alias NervesHub.Devices.CACertificate
+  alias NervesHub.Devices.Device
   alias NervesHub.Devices.DeviceCertificate
+  alias NervesHub.Devices.DeviceHealth
   alias NervesHub.Firmwares
   alias NervesHub.Fixtures
   alias NervesHub.Products
@@ -77,6 +79,21 @@ defmodule NervesHub.DevicesTest do
     assert {:error, _} = Devices.get_device_by_org(org, device.id)
   end
 
+  test "destroy_device", %{device: device} do
+    {:ok, _} =
+      Devices.save_device_health(%{
+        "device_id" => device.id,
+        "data" => %{},
+        "status" => :healthy,
+        "status_reasons" => %{}
+      })
+
+    {:ok, _device} = Devices.destroy_device(device)
+
+    assert is_nil(Repo.get(Device, device.id))
+    refute Repo.exists?(where(DeviceHealth, device_id: ^device.id))
+  end
+
   test "can tag multiple devices", %{
     user: user,
     device: device,