New UI: Allow deletion of scripts (#1845)

- Delete button (with confirm box) on edit script page.
- Adds `Scripts.delete/3` function.
- Audit log when script is deleted

Author: elinol

lib/nerves_hub/audit_logs/templates/product_templates.ex

@@ -20,4 +20,12 @@ defmodule NervesHub.AuditLogs.ProductTemplates do
 
     AuditLogs.audit!(user, product, description)
   end
+
+  @spec audit_script_deleted(User.t(), Product.t(), Script.t()) :: AuditLog.t()
+  def audit_script_deleted(user, product, script) do
+    description =
+      "User #{user.name} removed script named #{script.name} from product #{product.name}"
+
+    AuditLogs.audit!(user, product, description)
+  end
 end

lib/nerves_hub/scripts.ex

@@ -87,4 +87,20 @@ defmodule NervesHub.Scripts do
         {:error, changeset}
     end
   end
+
+  @spec delete(non_neg_integer(), Product.t(), User.t()) ::
+          {:ok, Ecto.Schema.t()} | {:error, Ecto.Changeset.t()}
+  def delete(id, product, user) do
+    get_by_product_and_id!(product, id)
+    |> Repo.delete()
+    |> case do
+      {:ok, script} ->
+        ProductTemplates.audit_script_deleted(user, product, script)
+
+        {:ok, script}
+
+      err ->
+        err
+    end
+  end
 end

lib/nerves_hub_web/live/support_scripts/edit-new.html.heex

@@ -45,10 +45,14 @@
             <div class="text-xs tracking-wide text-zinc-400">Make sure this is valid Elixir and will not crash the device</div>
           </div>
         </div>
-        <div class="flex justify-between items-center h-14 px-4 border-t border-zinc-700">
+        <div class="flex justify-start gap-4 items-center h-14 px-4 border-t border-zinc-700">
           <.button style="secondary" type="submit">
             <.icon name="save" /> Save changes
           </.button>
+
+          <.button style="danger" phx-click="delete-script" phx-value-id={@script.id} data-confirm="Are you sure you want to delete this script?">
+            <.icon name="trash" /> Delete Script
+          </.button>
         </div>
       </div>
     </.form>

lib/nerves_hub_web/live/support_scripts/edit.ex

@@ -42,4 +42,27 @@ defmodule NervesHubWeb.Live.SupportScripts.Edit do
         |> noreply()
     end
   end
+
+  @impl Phoenix.LiveView
+  def handle_event(
+        "delete-script",
+        %{"id" => id},
+        %{assigns: %{org: org, org_user: org_user, product: product}} = socket
+      ) do
+    authorized!(:"support_script:delete", org_user)
+
+    case Scripts.delete(id, product, org_user.user) do
+      {:ok, _} ->
+        socket
+        |> put_flash(:info, "Support Script deleted")
+        |> send_toast(:info, "Support Script deleted successfully.")
+        |> push_navigate(to: ~p"/org/#{org.name}/#{product.name}/scripts")
+        |> noreply()
+
+      {:error, _} ->
+        socket
+        |> send_toast(:error, "There was an error deleting the Support Script.")
+        |> noreply()
+    end
+  end
 end