Add support for OpenTelemetry tracing #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
joshk
force-pushed
the
open-telemetry-tracing
branch
from
9eb39cd to
3eda869
Compare
lawik
reviewed
Oct 28, 2024
Contributor
lawik
left a comment
lawik
left a comment
There was a problem hiding this comment.
It all made rough sense to me. I haven't done OTel specifically but looks reasonable.
Recommend others weighing in as well :)
joshk
force-pushed
the
open-telemetry-tracing
branch
from
3eda869 to
c7184bd
Compare
jjcarstens
approved these changes
Oct 28, 2024
joshk
force-pushed
the
open-telemetry-tracing
branch
from
922ded9 to
ac0b589
Compare
joshk
force-pushed
the
open-telemetry-tracing
branch
from
ac0b589 to
9c549fe
Compare
joshk
force-pushed
the
open-telemetry-tracing
branch
from
6ee3e2f to
9698b15
Compare
nshoes
approved these changes
Nov 18, 2024
| As devices update and reconnect, the new orchestrator is told that the update | ||
| was successful, and the process is repeated. | ||
| """ | ||
| @decorate with_span("Deployments.Orchestrator.trigger_update") |
Contributor
There was a problem hiding this comment.
I haven't seen this before, very cool 🤤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for:
Further work will need to be done for DeviceChannel bits
The default behavior is to trace everything, but I have added support for a percentage based sampler.
To use this with honeycomb you would configure it with:
It also interesting to note that Sentry is coming out with Elixir tracing support soon
I'd like to merge this in while I work more on the Oban OpenTelemetry PR: open-telemetry/opentelemetry-erlang-contrib#400