fix: update bytes from 1.10.1 to 1.11.1 (RUSTSEC-2026-0007)#5099
Merged
fix: update bytes from 1.10.1 to 1.11.1 (RUSTSEC-2026-0007)#5099
Conversation
Co-authored-by: eval-exec <46400566+eval-exec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix integer overflow in BytesMut::reserve
fix: update bytes from 1.10.1 to 1.11.1 (RUSTSEC-2026-0007)
Feb 4, 2026
driftluo
approved these changes
Feb 4, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
### What problem does this PR solve? Problem Summary: RUSTSEC-2026-0007: Integer overflow in `BytesMut::reserve` allows unchecked addition of `new_cap + offset` to wrap in release builds, corrupting capacity tracking and enabling out-of-bounds memory access. ### What is changed and how it works? What's Changed: - Bump `bytes` dependency from `1.10.1` to `1.11.1` in workspace `Cargo.toml` - Update `Cargo.lock` to reflect patched version Version 1.11.1 adds overflow checks to the reserve path, preventing capacity corruption. ### Related changes - N/A ### Check List Tests - No code Side effects - N/A <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>RUSTSEC-2026-0007: Integer overflow in `BytesMut::reserve`</issue_title> > <issue_description> > > Integer overflow in `BytesMut::reserve` > > | Details | | > | ------------------- | ---------------------------------------------- | > | Package | `bytes` | > | Version | `1.10.1` | > | URL | [https://github.com/advisories/GHSA-434x-w66g-qw3r](https://github.com/advisories/GHSA-434x-w66g-qw3r) | > | Date | 2026-02-03 | > | Patched versions | `>=1.11.1` | > | Unaffected versions | `<1.2.1` | > > In the unique reclaim path of `BytesMut::reserve`, the condition > ```rs > if v_capacity >= new_cap + offset > ``` > uses an unchecked addition. When `new_cap + offset` overflows `usize` in release builds, this condition may incorrectly pass, causing `self.cap` to be set to a value that exceeds the actual allocated capacity. Subsequent APIs such as `spare_capacity_mut()` then trust this corrupted `cap` value and may create out-of-bounds slices, leading to UB. > > This behavior is observable in release builds (integer overflow wraps), whereas debug builds panic due to overflow checks. > > ## PoC > > ```rs > use bytes::*; > > fn main() { > let mut a = BytesMut::from(&b"hello world"[..]); > let mut b = a.split_off(5); > > // Ensure b becomes the unique owner of the backing storage > drop(a); > > // Trigger overflow in new_cap + offset inside reserve > b.reserve(usize::MAX - 6); > > // This call relies on the corrupted cap and may cause UB & HBO > b.put_u8(b'h'); > } > ``` > > # Workarounds > > Users of `BytesMut::reserve` are only affected if integer overflow checks are configured to wrap. When integer overflow is configured to panic, this issue does not apply. > > See [advisory page](https://rustsec.org/advisories/RUSTSEC-2026-0007.html) for additional details. > </issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #5098 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: eval-exec <46400566+eval-exec@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
RUSTSEC-2026-0007: Integer overflow in
BytesMut::reserveallows unchecked addition ofnew_cap + offsetto wrap in release builds, corrupting capacity tracking and enabling out-of-bounds memory access.What is changed and how it works?
What's Changed:
bytesdependency from1.10.1to1.11.1in workspaceCargo.tomlCargo.lockto reflect patched versionVersion 1.11.1 adds overflow checks to the reserve path, preventing capacity corruption.
Related changes
Check List
Tests
Side effects
Original prompt
BytesMut::reserve#5098💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.