refactor: improve hold TLC settlement logic #1022
Open
+1,459
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
force-pushed
the
fix-over-paid-invoice
branch
4 times, most recently
from
08c3ea7 to
f9525ed
Compare
chenyukang
reviewed
Dec 30, 2025
| @@ -0,0 +1,262 @@ | |||
| use crate::{ | |||
Collaborator
There was a problem hiding this comment.
tile file name is not following our current naming style, suggest something like settle_tlcs.
chenyukang
reviewed
Dec 30, 2025
chenyukang
approved these changes
Dec 30, 2025
quake
reviewed
Dec 30, 2025
doitian
force-pushed
the
fix-over-paid-invoice
branch
4 times, most recently
from
8cae68e to
406370f
Compare
- Add invoice status validation - Ensure `RemoveTlc` is called for invalid TLCs - Reject overpaid TLCs for MPP invoices - For non-MPP invoices, accept only one fulfilled TLC and reject all others This refactoring ensures that, in the presence of multiple payments to the same invoice, at most one payment succeeds. However, due to the lack of database transaction support, there remains a small window where the total accepted amount may exceed the invoice amount. Additionally, in the case of two concurrent MPP payments, it's possible to partially accept TLCs from both without either payment fully succeeding. This is an inherent limitation of MPP and cannot be avoided on the recipient side. Closes nervosnetwork#965
doitian
force-pushed
the
fix-over-paid-invoice
branch
from
406370f to
3cc4011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor hold TLC settlement logic to improve payment handling:
RemoveTlcis called for invalid TLCsKey Changes
SettleTlcSetCommandmodule: Encapsulates TLC settlement logic with clear verification steps and settlement actionsSettleTlcSetinto two distinct commands:SettleTlcSet(payment_hash, tlc_ids)- Settle TLCs by given list of(channel_id, tlc_id)SettleHoldTlcSet(payment_hash)- Settle hold TLC set saved for a payment hashis_mppfield fromPendingNotifySettleTlcand simplified the settlement flowBehavior Notes
This refactoring ensures that, in the presence of multiple payments to the same invoice, at most one payment succeeds. However, due to the lack of database transaction support, there remains a small window where the total accepted amount may exceed the invoice amount.
Additionally, in the case of two concurrent MPP payments, it's possible to partially accept TLCs from both without either payment fully succeeding. This is an inherent limitation of MPP and cannot be avoided on the recipient side.
Related Issues
Closes #965