Fix old python issues #2841 and #2856 #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I sincerely request @imsys 's review. |
Contributor
Contributor
Author
|
I have sent a patch to fix #2856 according to #2856 (comment) by @imsys 's suggestion. |
Contributor
|
As I have reviewed, this fixes 10 carts. So, for me this is approved. My only comment is that there are two games (POP! FISHING and HEXAPIX) that still error with: |
nesbox
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is trying to fix #2841 and #2856, according to the report of @imsys .
See #2841 (comment) for progress.