feat: copy button #3084
Merged
feat: copy button #3084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a copy button in code block Co-authored-by: Guilherme Siquinelli <[email protected]>
ThiagoBussola
force-pushed
the
feat-clipboard
branch
from
52fc895 to
6112cad
Compare
micalevisk
reviewed
Sep 1, 2024
removing unnused console.log
micalevisk
approved these changes
Sep 2, 2024
micalevisk
approved these changes
Sep 2, 2024
4 tasks
src/app/shared/components/copy-button/copy-button.component.html
Outdated
Show resolved
Hide resolved
changing clipboard button and changing copied text to icon
| const filename = text.slice(startIndex + 1, endIndex); | ||
| return ( | ||
| ` | ||
| <app-copy-button> |
There was a problem hiding this comment.
Should we show the copy button for code snippets that don't have the filename specified?
Example:
I would think so
There was a problem hiding this comment.
I agree, copy button for code snippets without filenames would improve usability. Let’s go ahead with this change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently in the documentation there is no button to copy code snippets to the clipboard.
Issue Number: #2332
What is the new behavior?
Added a new button to copy code snippets to the clipboard
Does this PR introduce a breaking change?
Other information
Co-authored-by: Guilherme Siquinelli [email protected]