fix(@nestjs/cli): disable shell execution on unix to prevent command injection #3128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The CLI currently enables shell execution (
shell: true
) on all platforms when spawning child processes. This creates a command injection vulnerability on Unix-like systems (macOS/Linux) where shell metacharacters can be exploited to execute malicious commands.Commands containing
$()
,${}
, or other shell expansions can potentially execute arbitrary code on the system.Issue Number: #3064
What is the new behavior?
Shell execution is now disabled on Unix-like systems (macOS/Linux) while remaining enabled on Windows for compatibility. This prevents command injection attacks on Unix systems while maintaining cross-platform functionality.
Changes:
shell: false
- prevents shell metacharacter exploitationshell: true
- maintains compatibilityDoes this PR introduce a breaking change?
Other information