refactor(dependency): Remove tree-kill dependency #3157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove external tree-kill dependency and use only local tree-kill code
Closes #3156
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
start
action uses the abandonedtree-kill
library while swc compiler code uses local tree-kill code.Issue Number: 3156
What is the new behavior?
tree-kill
dependency is removed.start
action uses the local tree-kill code.Does this PR introduce a breaking change?
Other information
tree-kill
NPM package has some file descriptor related issues for some on MacOS due to issues with use ofspawn
command to create the shell process to build the process tree. Forks of this library, and the local tree-kill code, useexecSync
instead, which helps with this issue.