Skip to content

Conversation

gcstarr
Copy link

@gcstarr gcstarr commented Oct 1, 2025

Remove external tree-kill dependency and use only local tree-kill code

Closes #3156

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

start action uses the abandoned tree-kill library while swc compiler code uses local tree-kill code.

Issue Number: 3156

What is the new behavior?

tree-kill dependency is removed. start action uses the local tree-kill code.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

tree-kill NPM package has some file descriptor related issues for some on MacOS due to issues with use of spawn command to create the shell process to build the process tree. Forks of this library, and the local tree-kill code, use execSync instead, which helps with this issue.

Remove external tree-kill dependency and use local tree-kill code

Closes nestjs#3156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace abandoned tree-kill library (Issue with --watch on MacOS)
1 participant