fix(utils): tree-kill use spawn sync to fix node 24 crash #3235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On Node.js v24+ (specifically on macOS), running the CLI in watch mode (e.g.,
nest start --watch) crashes when a file change is detected.The error occurs in
getAllPidbecauseexecSyncattempts to spawn a shell (/bin/sh) to runps. Newer versions of Node.js have stricter handling of file descriptor inheritance during process reloading, causing the shell invocation to fail withEBADF.Error Log:
Issue Number: #3156
What is the new behavior?
The
getAllPidfunction now usesspawnSyncdirectly instead ofexecSync.psbinary directly (instead of via/bin/sh), we avoid the shell-related file descriptor issues on Node 24.stdio: 'pipe'to prevent invalid file descriptor inheritance.try/catchblock. Ifpsfails for any system-level reason, the CLI now defaults to an empty list (no processes found) rather than crashing the entire watch process.Does this PR introduce a breaking change?
Other information
nest start --watchcorrectly restarts the application after file changes without crashing.