Skip to content

Conversation

mag123c
Copy link
Contributor

@mag123c mag123c commented Oct 1, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When using ConfigurableModuleBuilder with .setExtras() and calling .registerAsync(), the transformModuleDefinition function receives async-specific options mixed with user-defined extras, making it impossible to distinguish between the two.

The transformModuleDefinition receives all keys including useFactory, but only folder and isGlobal should be passed as extras.

Issue Number: #15661

What is the new behavior?

The registerAsync method now correctly filters out async-specific keys before passing extras to transformModuleDefinition.
Only user-defined extras are included.

  • transformModuleDefinition now receives only user-defined extras
  • Async-specific configuration remains in the correct scope
  • No breaking changes to existing behavior

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 518296db-5633-4e2a-bf90-04dd47bb380c

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.71%

Totals Coverage Status
Change from base Build 8026c967-4d5f-4df2-829f-55427bc13a5c: 0.02%
Covered Lines: 7284
Relevant Lines: 8211

💛 - Coveralls

@mag123c mag123c changed the title fix(common): resolve extras in configurable module builder async methods fix(core): resolve extras in configurable module builder async methods Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants