fix(core): resolve extras in configurable module builder async methods #15705
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 518296db-5633-4e2a-bf90-04dd47bb380cDetails
💛 - Coveralls |
4 tasks
mag123c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
ConfigurableModuleBuilderwith.setExtras()and calling.registerAsync(), thetransformModuleDefinitionfunction receives async-specific options mixed with user-defined extras, making it impossible to distinguish between the two.The transformModuleDefinition receives all keys including useFactory, but only folder and isGlobal should be passed as extras.
Issue Number: #15661
What is the new behavior?
The registerAsync method now correctly filters out async-specific keys before passing extras to transformModuleDefinition.
Only user-defined extras are included.
Does this PR introduce a breaking change?