Skip to content

Allow for spaces in Windows file paths #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow for spaces in Windows file paths #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7444c1e
Fix spaces in windows path
cb-nvs Dec 30, 2024
b65ca6a
Check for "'" in windows paths with space
cb-nvs Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/net/scp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,13 @@ def scp_command(mode, options)
def start_command(mode, local, remote, options={}, &callback)
session.open_channel do |channel|

if options[:shell]
if options[:windows_path]
escaped_file = remote.gsub(/'/) { |m| '/' }
unless escaped_file.index(' ').nil? || escaped_file.match?(/^'.+'$/)
escaped_file = "'#{escaped_file}'"
end
command = "#{scp_command(mode, options)} #{escaped_file}"
elsif options[:shell]
escaped_file = shellescape(remote).gsub(/'/) { |m| "'\\''" }
command = "#{options[:shell]} -c '#{scp_command(mode, options)} #{escaped_file}'"
else
Expand Down