Fix for missing isfinnish parameter#27
Open
teliarokaspaulikas wants to merge 2 commits intonet9-oy:masterfrom
Open
Fix for missing isfinnish parameter#27teliarokaspaulikas wants to merge 2 commits intonet9-oy:masterfrom
teliarokaspaulikas wants to merge 2 commits intonet9-oy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #26
Added conditional check for
$postal->setIsFinnish($details['Country'] === 'FI') ? '1' : '0'because setFinnish function wrongly useshtmlspecialchars($isFinnish, ENT_COMPAT, "UTF-8");because when it receives false boolean value, the result of the function is an empty string.