Skip to content

Fixed MONSTER BERE Function Implementation and Expanded MONSTER Testing#384

Merged
taraeicher merged 5 commits intonetZoo:develfrom
taraeicher:monsterBERE_patch
Mar 4, 2026
Merged

Fixed MONSTER BERE Function Implementation and Expanded MONSTER Testing#384
taraeicher merged 5 commits intonetZoo:develfrom
taraeicher:monsterBERE_patch

Conversation

@taraeicher
Copy link
Contributor

  • Removed redundant code implementing BERE function to compute MONSTER transition matrix (MONSTER BERE Estimation Returns Empty Correlation Matrix in buildNet Mode #377).
  • Removed options for unimplemented GRN computation methods in buildNet mode.
  • Removed unnecessary logging messages which make the code more difficult to debug during build. Added option to enable or disable logging.
  • Expanded MONSTER testing to ensure that various combinations of inputs run without error in both regNet and buildNet mode.

@taraeicher taraeicher self-assigned this Mar 4, 2026
@taraeicher taraeicher added the bug Something isn't working label Mar 4, 2026
@taraeicher taraeicher merged commit a0a066f into netZoo:devel Mar 4, 2026
8 checks passed
@taraeicher taraeicher deleted the monsterBERE_patch branch March 4, 2026 17:25
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 62.79070% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.70%. Comparing base (f84c392) to head (aa635f9).
⚠️ Report is 6 commits behind head on devel.

Files with missing lines Patch % Lines
R/MONSTER.R 62.79% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #384      +/-   ##
==========================================
+ Coverage   57.62%   59.70%   +2.08%     
==========================================
  Files          21       21              
  Lines        3530     3507      -23     
==========================================
+ Hits         2034     2094      +60     
+ Misses       1496     1413      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant