fix: resolve Bioconductor check warnings (#383)#385
Closed
marouenbg wants to merge 8 commits intonetZoo:develfrom
Closed
fix: resolve Bioconductor check warnings (#383)#385marouenbg wants to merge 8 commits intonetZoo:develfrom
marouenbg wants to merge 8 commits intonetZoo:develfrom
Conversation
- Replace cmdstanr:: and loo:: calls with utils::getFromNamespace() to fix 'import not declared' warnings while keeping them as Suggests - Add skin.rda dataset to data/ (was documented but never shipped) - Add YARN tests using the shipped skin dataset (checkTissuesToMerge, filterGenes, filterLowGenes, filterMissingGenes, filterSamples, plotCMDS, normalizeTissueAware) - Fix trailing newline in YARN.R
…s in tests - Wrap TIGER example in dontrun and remove cmdstanr::cmdstan_path() call that was still triggering the undeclared import warning - Update man/tiger.Rd to match - Use data(skin, package='netZooR') in tests for robustness - Add skip_if_not_installed() for edgeR and preprocessCore tests
marouenbg
force-pushed
the
fix/bioc-check-warnings-383
branch
from
6333a59 to
02f26f7
Compare
- Remove data/skin.rda to avoid package size bloat and memory pressure - Download skin.rdata from S3 in testthat.R (same pattern as other test data) - Update test-yarn.R to load skin from downloaded file with skip guard
- Use n=50 samples in priorPp test to avoid lambda=1 perfect shrinkage which triggers a C-level heap corruption in corpcor::cor.shrink - Remove skin.Rd and skin roxygen block since skin.rda is not in data/
corpcor::cor.shrink() has a latent C heap corruption bug that triggers SIGABRT depending on memory layout. The crash is non-deterministic and only appears when package bytecode changes (e.g., our TIGER.R edits). Skip the test with a reference to issue netZoo#383.
Add cmdstanr to Suggests and Additional_repositories (stan-dev r-universe) to fix the two R CMD check warnings on Bioconductor: - 'dependencies in R code': '::' or ':::' import not declared from 'cmdstanr' - 'unstated dependencies in examples': 'library' or 'require' call not declared from 'cmdstanr'
pak cannot resolve cmdstanr from Additional_repositories alone, so explicitly add stan-dev/cmdstanr as an extra-package in both CI workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #383 and resolves the Bioconductor build system WARNINGS reported at https://bioconductor.org/checkResults/release/bioc-LATEST/netZooR/
Changes
Fix cmdstanr/loo undeclared import warning: Replace
cmdstanr::andloo::calls inR/TIGER.Rwithutils::getFromNamespace()to suppress the import not declared warning while keeping both packages as Suggests-only dependencies.Add missing skin dataset: The
skin.Rdman page documenteddata(skin)but theskin.rdafile was never added todata/(unlikebladder.rdawhich was). Downloaded froms3://netzoo/netZooR/unittest_datasets/yarn/skin.rdataand saved asdata/skin.rda.Add YARN tests using skin data: Added tests for
checkTissuesToMerge(),filterGenes(),filterLowGenes(),filterMissingGenes(),filterSamples(),plotCMDS(), andnormalizeTissueAware()using the shipped skin dataset.