Skip to content

Updates to allow a Spine switch without VTEP #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Updates to allow a Spine switch without VTEP #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35074d1
Fix for issue #662
Oct 31, 2025
112a88b
Fixed missing comma.
Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion roles/dtc/common/templates/ndfc_underlay_ip_address.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
{%- set _ = switch_list.update({
switch.name: {
'management_ipv4_address': switch.management.management_ipv4_address,
'serial_number': switch.serial_number
'serial_number': switch.serial_number,
'role': switch.role
}
}) %}
{%- endfor %}
Expand All @@ -23,13 +24,15 @@
{%- set ns.ipv4 = interface.ipv4_address %}
{%- endif %}
{%- endfor %}
{% if not (switch.role == 'spine' and loopback_id == vtep_lo_id) %}
- entity_name: "{{ switch_list[switch.name].serial_number }}~loopback{{ loopback_id }}"
pool_type: IP
pool_name: "LOOPBACK{{ loopback_id }}_IP_POOL"
scope_type: device_interface
resource: "{{ ns.ipv4 }}"
switch:
- "{{ switch_list[switch.name].management_ipv4_address }}"
{% endif %}
{% endfor %}
{% endmacro %}
{# resource for routing loopback #}
Expand Down
4 changes: 3 additions & 1 deletion roles/validate/files/rules/ibgp_vxlan/208_manual_ipaddress_allocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ def match(cls, data_model):
vtep_loopback_name = f"loopback{underlay_vtep_loopback_id}"
vtep_loopback_found = cls.check_interface_with_ipv4(interfaces, vtep_loopback_name)

if not vtep_loopback_found:
switch_role = switch.get("role", "").lower()

if not vtep_loopback_found and switch_role != "spine":
cls.results.append(
f"Switch '{switch_name}' is missing a configured interface '{vtep_loopback_name}' with an IPv4 address."
)
Expand Down