'fp.monitoring' fixed and expanded (Issue623) #267
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| version: '>= 0.14.0' | ||
|
|
||
| formatter: markdown table | ||
|
|
||
| content: |- | ||
| # Terraform ACI User-Defined Monitoring Policy Module | ||
|
|
||
| Manages ACI User-Defined Monitoring Policy | ||
|
|
||
| Location in GUI: | ||
| `Fabric` » `Fabric Policies` » `Policies` » `Monitoring` | ||
|
|
||
| ## Examples | ||
|
|
||
| ```hcl | ||
| {{ include "./examples/complete/main.tf" }} | ||
| ``` | ||
|
|
||
| {{ .Requirements }} | ||
|
|
||
| {{ .Providers }} | ||
|
|
||
| {{ .Inputs }} | ||
|
|
||
| {{ .Outputs }} | ||
|
|
||
| {{ .Resources }} | ||
|
|
||
| output: | ||
| file: README.md | ||
| mode: replace | ||
|
|
||
| sort: | ||
| enabled: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| <!-- BEGIN_TF_DOCS --> | ||
| # Terraform ACI User-Defined Monitoring Policy Module | ||
|
|
||
| Manages ACI User-Defined Monitoring Policy | ||
|
|
||
| Location in GUI: | ||
| `Fabric` » `Fabric Policies` » `Policies` » `Monitoring` | ||
|
|
||
| ## Examples | ||
|
|
||
| ```hcl | ||
| module "aci_monitoring_policy_user_defined" { | ||
| source = "netascode/nac-aci/aci//modules/terraform-aci-monitoring-policy-user-defined" | ||
| version = "> 1.0.1" | ||
|
|
||
| name = "MON1" | ||
| snmp_trap_policies = [{ | ||
| name = "SNMP_1" | ||
| destination_group = "SNMP_DEST_GROUP1" | ||
| }] | ||
| syslog_policies = [{ | ||
| name = "SYSLOG1" | ||
| audit = false | ||
| events = false | ||
| faults = false | ||
| session = true | ||
| minimum_severity = "alerts" | ||
| destination_group = "SYSLOG_DEST_GROUP1" | ||
| }] | ||
| fault_severity_policies = [{ | ||
| class = "snmpClient" | ||
| faults = [{ | ||
| fault_id = "F1368" | ||
| description = "Fault 1368 nice description" | ||
| initial_severity = "critical" | ||
| target_severity = "inherit" | ||
| }] | ||
| }] | ||
| } | ||
| ``` | ||
|
|
||
| ## Requirements | ||
|
|
||
| | Name | Version | | ||
| |------|---------| | ||
| | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 | | ||
| | <a name="requirement_aci"></a> [aci](#requirement\_aci) | >= 2.15.0 | | ||
|
|
||
| ## Providers | ||
|
|
||
| | Name | Version | | ||
| |------|---------| | ||
| | <a name="provider_aci"></a> [aci](#provider\_aci) | >= 2.15.0 | | ||
|
|
||
| ## Inputs | ||
|
|
||
| | Name | Description | Type | Default | Required | | ||
| |------|-------------|------|---------|:--------:| | ||
| | <a name="input_name"></a> [name](#input\_name) | Track List name. | `string` | n/a | yes | | ||
| | <a name="input_description"></a> [description](#input\_description) | Description. | `string` | `""` | no | | ||
| | <a name="input_snmp_trap_policies"></a> [snmp\_trap\_policies](#input\_snmp\_trap\_policies) | List of SNMP trap policies. | <pre>list(object({<br/> name = string<br/> destination_group = optional(string, "")<br/> }))</pre> | `[]` | no | | ||
| | <a name="input_syslog_policies"></a> [syslog\_policies](#input\_syslog\_policies) | List of syslog policies. Default value `audit`: true. Default value `events`: true. Default value `faults`: true. Default value `session`: false. Default value `minimum_severity`: `warnings`. | <pre>list(object({<br/> name = string<br/> audit = optional(bool, true)<br/> events = optional(bool, true)<br/> faults = optional(bool, true)<br/> session = optional(bool, false)<br/> minimum_severity = optional(string, "warnings")<br/> destination_group = optional(string, "")<br/> }))</pre> | `[]` | no | | ||
| | <a name="input_fault_severity_policies"></a> [fault\_severity\_policies](#input\_fault\_severity\_policies) | List of Fault Severity Assignment Policies. | <pre>list(object({<br/> class = string<br/> faults = list(object({<br/> fault_id = string<br/> initial_severity = optional(string, "inherit")<br/> target_severity = optional(string, "inherit")<br/> description = optional(string, "")<br/> }))<br/> }))</pre> | `[]` | no | | ||
|
|
||
| ## Outputs | ||
|
|
||
| | Name | Description | | ||
| |------|-------------| | ||
| | <a name="output_dn"></a> [dn](#output\_dn) | Distinguished name of Fabric `monFabricPol` object. | | ||
| | <a name="output_name"></a> [name](#output\_name) | User-Defined Fabric Monitoring Policy name. | | ||
|
|
||
| ## Resources | ||
|
|
||
| | Name | Type | | ||
| |------|------| | ||
| | [aci_rest_managed.faultSevAsnP](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| | [aci_rest_managed.monFabricPol](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| | [aci_rest_managed.monFabricTarget](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| | [aci_rest_managed.snmpRsDestGroup](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| | [aci_rest_managed.snmpSrc](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| | [aci_rest_managed.syslogRsDestGroup](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| | [aci_rest_managed.syslogSrc](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/rest_managed) | resource | | ||
| <!-- END_TF_DOCS --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| version: '>= 0.14.0' | ||
|
|
||
| formatter: markdown table | ||
|
|
||
| content: |- | ||
| # Monitoring Policy Example | ||
|
|
||
| To run this example you need to execute: | ||
|
|
||
| ```bash | ||
| $ terraform init | ||
| $ terraform plan | ||
| $ terraform apply | ||
| ``` | ||
|
|
||
| Note that this example will create resources. Resources can be destroyed with `terraform destroy`. | ||
|
|
||
| ```hcl | ||
| {{ include "./main.tf" }} | ||
| ``` | ||
|
|
||
| output: | ||
| file: README.md | ||
| mode: replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <!-- BEGIN_TF_DOCS --> | ||
| # Monitoring Policy Example | ||
|
|
||
| To run this example you need to execute: | ||
|
|
||
| ```bash | ||
| $ terraform init | ||
| $ terraform plan | ||
| $ terraform apply | ||
| ``` | ||
|
|
||
| Note that this example will create resources. Resources can be destroyed with `terraform destroy`. | ||
|
|
||
| ```hcl | ||
| module "aci_monitoring_policy_user_defined" { | ||
| source = "netascode/nac-aci/aci//modules/terraform-aci-monitoring-policy-user-defined" | ||
| version = "> 1.0.1" | ||
|
|
||
| name = "MON1" | ||
| snmp_trap_policies = [{ | ||
| name = "SNMP_1" | ||
| destination_group = "SNMP_DEST_GROUP1" | ||
| }] | ||
| syslog_policies = [{ | ||
| name = "SYSLOG1" | ||
| audit = false | ||
| events = false | ||
| faults = false | ||
| session = true | ||
| minimum_severity = "alerts" | ||
| destination_group = "SYSLOG_DEST_GROUP1" | ||
| }] | ||
| fault_severity_policies = [{ | ||
| class = "snmpClient" | ||
| faults = [{ | ||
| fault_id = "F1368" | ||
| description = "Fault 1368 nice description" | ||
| initial_severity = "critical" | ||
| target_severity = "inherit" | ||
| }] | ||
| }] | ||
| } | ||
| ``` | ||
| <!-- END_TF_DOCS --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| module "aci_monitoring_policy_user_defined" { | ||
| source = "netascode/nac-aci/aci//modules/terraform-aci-monitoring-policy-user-defined" | ||
| version = "> 1.0.1" | ||
|
|
||
| name = "MON1" | ||
| snmp_trap_policies = [{ | ||
| name = "SNMP_1" | ||
| destination_group = "SNMP_DEST_GROUP1" | ||
| }] | ||
| syslog_policies = [{ | ||
| name = "SYSLOG1" | ||
| audit = false | ||
| events = false | ||
| faults = false | ||
| session = true | ||
| minimum_severity = "alerts" | ||
| destination_group = "SYSLOG_DEST_GROUP1" | ||
| }] | ||
| fault_severity_policies = [{ | ||
| class = "snmpClient" | ||
| faults = [{ | ||
| fault_id = "F1368" | ||
| description = "Fault 1368 nice description" | ||
| initial_severity = "critical" | ||
| target_severity = "inherit" | ||
| }] | ||
| }] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
|
|
||
| terraform { | ||
| required_version = ">= 1.3.0" | ||
|
|
||
| required_providers { | ||
| aci = { | ||
| source = "CiscoDevNet/aci" | ||
| version = ">= 2.15.0" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe lets call it aci_monitoring_policy_common and 2nd module just aci_monitoring_policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and lets add there fault severity policies (for common object), to keep all modules supporting the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the way, i guess there is not an option to configure new syslog destination or snmp destination without adding it to common object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can check this with Justyna. I tried to keep it the way it is in order to ensure backwards compatibility.
As per my tests, common policy does not allow changes in Fault severities.
Not sure about this one. Hope you can elaborate it