fix: extend library condition resources to 7-level nesting#48
Draft
ChristopherJHart wants to merge 1 commit intonetascode:mainfrom
Draft
fix: extend library condition resources to 7-level nesting#48ChristopherJHart wants to merge 1 commit intonetascode:mainfrom
ChristopherJHart wants to merge 1 commit intonetascode:mainfrom
Conversation
The ise_network_access_condition and ise_device_admin_condition resource blocks only supported 2 levels of children nesting (c -> c2). ISE supports deeply nested condition hierarchies with ConditionAndBlock/ConditionOrBlock at arbitrary depth. Extend both resource blocks to support 7 levels of children nesting (c -> c2 -> c3 -> c4 -> c5 -> c6), matching the depth used for inline policy set conditions in PR netascode#41. Related: netascode/nac-ise#34, netascode#41 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ise_network_access_conditionresource block from 2 to 7 levels of children nestingise_device_admin_conditionresource block from 2 to 7 levels of children nestingPR #41 extended inline policy set/rule condition nesting to 7 levels but did not update the library condition resource blocks (
ise_network_access_condition,ise_device_admin_condition). These blocks remained at 2 levels of nesting (c → c2), preventing deeply nested reusable/library conditions from being propagated to ISE.This PR extends both resource blocks to support 7 levels (
c → c2 → c3 → c4 → c5 → c6), matching the inline condition depth.Related Issues/PRs
Test plan
terraform applycreates deeply nested library conditions on ISE 3.4+🤖 AI Generation Metadata
🤖 Generated with Claude Code