Skip to content

fix: extend library condition resources to 7-level nesting#48

Draft
ChristopherJHart wants to merge 1 commit intonetascode:mainfrom
ChristopherJHart:fix/library-condition-deep-nesting
Draft

fix: extend library condition resources to 7-level nesting#48
ChristopherJHart wants to merge 1 commit intonetascode:mainfrom
ChristopherJHart:fix/library-condition-deep-nesting

Conversation

@ChristopherJHart
Copy link

Summary

  • Extend ise_network_access_condition resource block from 2 to 7 levels of children nesting
  • Extend ise_device_admin_condition resource block from 2 to 7 levels of children nesting

PR #41 extended inline policy set/rule condition nesting to 7 levels but did not update the library condition resource blocks (ise_network_access_condition, ise_device_admin_condition). These blocks remained at 2 levels of nesting (c → c2), preventing deeply nested reusable/library conditions from being propagated to ISE.

This PR extends both resource blocks to support 7 levels (c → c2 → c3 → c4 → c5 → c6), matching the inline condition depth.

Related Issues/PRs

Test plan

  • Validate Terraform plan succeeds with library conditions containing 3+ levels of nesting
  • Verify terraform apply creates deeply nested library conditions on ISE 3.4+
  • Confirm no regression for existing 2-level library conditions

🤖 AI Generation Metadata

  • AI Generated: Yes
  • AI Tool: claude-code
  • AI Model: opus-4.6
  • AI Contribution: ~100%
  • AI Reason: extend library condition nesting to 7 levels
  • Human Oversight: Code reviewed and approved by user

🤖 Generated with Claude Code

The ise_network_access_condition and ise_device_admin_condition resource
blocks only supported 2 levels of children nesting (c -> c2). ISE supports
deeply nested condition hierarchies with ConditionAndBlock/ConditionOrBlock
at arbitrary depth.

Extend both resource blocks to support 7 levels of children nesting
(c -> c2 -> c3 -> c4 -> c5 -> c6), matching the depth used for inline
policy set conditions in PR netascode#41.

Related: netascode/nac-ise#34, netascode#41

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ChristopherJHart ChristopherJHart marked this pull request as draft March 2, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant