Added VPC configuration support #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice-specific > configuration_template > device_group > global
make interface group variables interpolation work
make config template variables interpolation work with precedence: de…
…mplates. variables interpolation precedence: device_specific > configuration_template > device_group > global
…_group-level > device_group-devel > global
- Add nxos_vpc_domain resource for VPC domain configuration - Add nxos_vpc_keepalive resource for VPC keepalive settings - Add nxos_vpc_peerlink resource for VPC peer-link configuration - Add nxos_vpc_interface resource for VPC member interfaces - Update main.tf to include VPC resources in dependencies - Add VPC defaults to defaults.yaml - Update README.md with VPC resource documentation - Add comprehensive VPC example with documentation This enables full VPC lifecycle management including: - VPC domain setup with role priority and system MAC - Keepalive configuration for failure detection - Peer-link configuration for synchronization - Member interface assignment with VPC IDs Supports both ethernet and port-channel interfaces as VPC members.
danischm
requested changes
Jul 30, 2025
nxos_vpc.tf
Outdated
| key = format("%s/%s", device.name, local.device_config[device.name].vpc_domain.domain_id) | ||
| device = device.name | ||
| domain_id = try(local.device_config[device.name].vpc_domain.domain_id, local.defaults.nxos.devices.configuration.vpc_domains.domain_id, null) | ||
| admin_state = try(local.device_config[device.name].vpc_domain.admin_state, local.defaults.nxos.devices.configuration.vpc_domains.admin_state, true) |
Member
There was a problem hiding this comment.
Preferably we do not hardcode default values in the code but rather define them in defaults.yaml and use "null" (omit) as a last resort.
Contributor
Author
There was a problem hiding this comment.
Updated with the 'return null' principle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tried to fix these issues: