fix(kubernetes-operator): change webhook container port to service targetPort#42
Open
aslafy-z wants to merge 1 commit intonetbirdio:mainfrom
Open
fix(kubernetes-operator): change webhook container port to service targetPort#42aslafy-z wants to merge 1 commit intonetbirdio:mainfrom
aslafy-z wants to merge 1 commit intonetbirdio:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Helm chart deployment for the Kubernetes operator so the container’s webhook port matches the Service’s configured targetPort, aligning the Pod’s declared containerPort with how traffic is actually routed.
Changes:
- Switch
containerPortfrom.Values.webhook.service.portto.Values.webhook.service.targetPortfor the webhook server container port.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
aslafy-z
changed the title
aslafy-z
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the deployment to advertise the right port in the container ports mapping.