-
-
Notifications
You must be signed in to change notification settings - Fork 893
[client] Add WireGuard interface lifecycle monitoring #4370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
64bb6db
[client] Add WireGuard interface lifecycle monitoring
hakansa 6016dbd
[client] Enhance WireGuard interface monitoring
hakansa 88f98a0
[client] Introduce WGIfaceMonitor for enhanced WireGuard interface ma…
hakansa bf5e12d
Refactor WGIfaceMonitor to use context for lifecycle management and i…
hakansa 6cc8df9
Clarify error handling in WGIfaceMonitor.Start method documentation
hakansa f37cc27
Refactor WGIfaceMonitor.Start to return restart indication and improv…
hakansa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -464,6 +464,9 @@ func (e *Engine) Start() error { | |||||
|
||||||
// starting network monitor at the very last to avoid disruptions | ||||||
e.startNetworkMonitor() | ||||||
|
||||||
// monitor WireGuard interface lifecycle and restart engine on changes | ||||||
e.startWGIfaceMonitor() | ||||||
return nil | ||||||
} | ||||||
|
||||||
|
@@ -1701,6 +1704,63 @@ func (e *Engine) startNetworkMonitor() { | |||||
}() | ||||||
} | ||||||
|
||||||
// startWGIfaceMonitor starts a background watcher that restarts the engine if | ||||||
// the WireGuard interface is created or deleted externally while the engine is running. | ||||||
// It relies on the engine context cancellation to stop. | ||||||
func (e *Engine) startWGIfaceMonitor() { | ||||||
hakansa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
// wgInterface should be initialized at this point | ||||||
if e.wgInterface == nil { | ||||||
return | ||||||
} | ||||||
|
||||||
name := e.wgInterface.Name() | ||||||
hakansa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
if name == "" { | ||||||
return | ||||||
} | ||||||
|
||||||
// Polling approach for cross-platform simplicity | ||||||
go func(ctx context.Context, ifaceName string) { | ||||||
log.Infof("Interface monitor: watching %s", ifaceName) | ||||||
|
||||||
// Determine initial state | ||||||
prevExists := interfaceExists(ifaceName) | ||||||
hakansa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
|
||||||
ticker := time.NewTicker(2 * time.Second) | ||||||
|
ticker := time.NewTicker(2 * time.Second) | |
ticker := time.NewTicker(wgIfaceMonitorPollInterval) |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
hakansa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
hakansa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.