Skip to content

Fix: Signal container backend port set to right value #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x-504 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix: Signal container backend port set to right value #5039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions infrastructure_files/docker-compose.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ services:
- $SIGNAL_VOLUMENAME:/var/lib/netbird
- $LETSENCRYPT_VOLUMENAME:/etc/letsencrypt:ro
ports:
- $NETBIRD_SIGNAL_PORT:80
- $NETBIRD_SIGNAL_PORT:$NETBIRD_SIGNAL_PORT
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Port mapping and listening port are mismatched.

Line 49 maps $NETBIRD_SIGNAL_PORT:$NETBIRD_SIGNAL_PORT (container port), but line 57 configures the signal service to listen on port 80. This mismatch will break the service—traffic sent to the container's $NETBIRD_SIGNAL_PORT won't reach the process listening on port 80.

🔎 Proposed fix 
    command: [
      "--cert-file", "$NETBIRD_MGMT_API_CERT_FILE",
      "--cert-key", "$NETBIRD_MGMT_API_CERT_KEY_FILE",
      "--log-file", "console",
-      "--port", "80"
+      "--port", "$NETBIRD_SIGNAL_PORT"
    ]

Also applies to: 53-58

🤖 Prompt for AI Agents 
In @infrastructure_files/docker-compose.yml.tmpl at line 49, The docker compose
port mapping uses $NETBIRD_SIGNAL_PORT as the container port but the service
process is configured to listen on port 80, causing a mismatch; fix by making
the host:container mapping match the process port (e.g., change the port mapping
entry from "- $NETBIRD_SIGNAL_PORT:$NETBIRD_SIGNAL_PORT" to "-
$NETBIRD_SIGNAL_PORT:80") or alternatively change the signal service to listen
on $NETBIRD_SIGNAL_PORT so both sides use the same port; apply the same
consistent change for the other occurrences in the signal service block (the
entries around 53-58).

# # port and command for Let's Encrypt validation
# - 443:443
# command: ["--letsencrypt-domain", "$NETBIRD_LETSENCRYPT_DOMAIN", "--log-file", "console"]
Expand Down Expand Up @@ -95,7 +95,7 @@ services:
environment:
- NETBIRD_STORE_ENGINE_POSTGRES_DSN=$NETBIRD_STORE_ENGINE_POSTGRES_DSN
- NETBIRD_STORE_ENGINE_MYSQL_DSN=$NETBIRD_STORE_ENGINE_MYSQL_DSN

# Coturn
coturn:
<<: *default
Expand Down