Skip to content

[misc] add additional cname example#5341

Merged
mlsmaycon merged 1 commit intomainfrom
add-additional-cname
Feb 16, 2026
Merged

[misc] add additional cname example#5341
mlsmaycon merged 1 commit intomainfrom
add-additional-cname

Conversation

@mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Feb 16, 2026

Describe your changes

image

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

netbirdio/docs#606

Summary by CodeRabbit

  • Documentation
    • Updated setup instructions to clarify proxy domain configuration guidance with an explicit sample mapping reference for Traefik configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

📝 Walkthrough

Walkthrough

The getting-started.sh file's Traefik instructions were updated to pluralize "example" to "examples" and include an explicit sample mapping line demonstrating the proxy domain configuration with a CNAME reference.

Changes

Cohort / File(s) Summary
Traefik Proxy Instructions
infrastructure_files/getting-started.sh
Updated reverse-proxy setup text from "example" to "examples" and added explicit sample mapping line for PROXY_DOMAIN as a CNAME to NETBIRD_DOMAIN.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • lixmal
  • braginini

Poem

🐰 A tweak to the docs, so small yet so sweet,
Where examples now blossom in plural retreat,
The CNAME revealed in its rightful display,
Getting started just clearer in every way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete: missing detailed change description, issue ticket number, and docs PR URL field is a placeholder. Provide a clear description of changes, link the related issue ticket, and fill in the actual docs PR URL (currently shows placeholder '__'). The image alone does not adequately describe the changes.
Title check ❓ Inconclusive The title '[misc] add additional cname example' is vague and doesn't clearly describe what change was made or why it matters. Use a more descriptive title that explains the specific documentation improvement, such as 'Update Traefik proxy domain configuration example with CNAME mapping' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-additional-cname

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@mlsmaycon mlsmaycon merged commit 0d1ffba into main Feb 16, 2026
55 of 61 checks passed
@mlsmaycon mlsmaycon deleted the add-additional-cname branch February 16, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants