Skip to content

feat(talos): add overridable timeout for auto install#1644

Open
ruant wants to merge 1 commit intonetbootxyz:developmentfrom
ruant:patch-1
Open

feat(talos): add overridable timeout for auto install#1644
ruant wants to merge 1 commit intonetbootxyz:developmentfrom
ruant:patch-1

Conversation

@ruant
Copy link
Copy Markdown

@ruant ruant commented Jun 29, 2025

I guess most people just want talos to get autoinstalled. I do atleast.

I set the timeout to be 60 seconds by default, but perhaps a better solution is to keep todays functionality, aka do not proceed and someone has to manually hit enter. Not sure how that is done tho?

I guess most people just want talos to get autoinstalled. I do atleast.
@antonym
Copy link
Copy Markdown
Member

antonym commented Jul 13, 2025

@claude review

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jul 13, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

1 similar comment
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jul 13, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

@antonym
Copy link
Copy Markdown
Member

antonym commented Aug 8, 2025

@claude please review

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Aug 8, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an automatic timeout feature to the Talos menu, allowing the menu to automatically proceed to installation after 60 seconds without requiring manual user intervention. The timeout is configurable via the install_timeout variable.

Key Changes:

  • Adds a default 60-second timeout to the Talos menu selection
  • Introduces the install_timeout variable with a default value of 60000 milliseconds
  • Modifies the choose command to include the timeout parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

isset ${talos_version} || set talos_version latest
isset ${talos_mirror} || set talos_mirror {{ releases.talos.mirror }}
isset ${talos_platform} || set talos_platform metal
isset ${install_timeout} || set install_timeout 60000
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name install_timeout is too generic and could conflict with other menu contexts. Consider using a more specific name like talos_timeout or talos_menu_timeout to follow the pattern established by other Talos-specific variables like talos_version, talos_mirror, and talos_platform.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants