feat(talos): add overridable timeout for auto install#1644
feat(talos): add overridable timeout for auto install#1644ruant wants to merge 1 commit intonetbootxyz:developmentfrom
Conversation
I guess most people just want talos to get autoinstalled. I do atleast.
|
@claude review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
1 similar comment
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
@claude please review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
Pull request overview
This PR adds an automatic timeout feature to the Talos menu, allowing the menu to automatically proceed to installation after 60 seconds without requiring manual user intervention. The timeout is configurable via the install_timeout variable.
Key Changes:
- Adds a default 60-second timeout to the Talos menu selection
- Introduces the
install_timeoutvariable with a default value of 60000 milliseconds - Modifies the
choosecommand to include the timeout parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| isset ${talos_version} || set talos_version latest | ||
| isset ${talos_mirror} || set talos_mirror {{ releases.talos.mirror }} | ||
| isset ${talos_platform} || set talos_platform metal | ||
| isset ${install_timeout} || set install_timeout 60000 |
There was a problem hiding this comment.
The variable name install_timeout is too generic and could conflict with other menu contexts. Consider using a more specific name like talos_timeout or talos_menu_timeout to follow the pattern established by other Talos-specific variables like talos_version, talos_mirror, and talos_platform.
I guess most people just want talos to get autoinstalled. I do atleast.
I set the timeout to be 60 seconds by default, but perhaps a better solution is to keep todays functionality, aka do not proceed and someone has to manually hit enter. Not sure how that is done tho?