Skip to content

fix: remove hardcoded http:// prefix from archlinux_mirror URLs #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonym wants to merge 1 commit into
base: development
Choose a base branch
from
+4 −4
Open

fix: remove hardcoded http:// prefix from archlinux_mirror URLs #1704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/netbootxyz/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ releases:
base_dir: archlinux
enabled: true
menu: linux
mirror: mirrors.kernel.org
mirror: http://mirrors.kernel.org
name: Arch Linux
versions:
- code_name: 2025.11.01
Expand Down
6 changes: 3 additions & 3 deletions roles/netbootxyz/templates/menu/archlinux.ipxe.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ iseq ${os_arch} i686 && goto boot32 ||
:boot
imgfree
set dir ${archlinux_base_dir}/iso/${arch_version}/arch/boot
set params archiso_http_srv=http://${real_archlinux_mirror}/${archlinux_base_dir}/iso/${arch_version}/ archisobasedir=arch cms_verify=y ${ipparam} net.ifnames=0 {{ kernel_params }}
kernel http://${archlinux_mirror}/${dir}/${os_arch}/vmlinuz-linux ${params}
initrd http://${archlinux_mirror}/${dir}/${os_arch}/initramfs-linux.img
set params archiso_http_srv=${real_archlinux_mirror}/${archlinux_base_dir}/iso/${arch_version}/ archisobasedir=arch cms_verify=y ${ipparam} net.ifnames=0 {{ kernel_params }}
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent variable usage: this line uses real_archlinux_mirror while lines 40-41 use archlinux_mirror. In static IP configurations, real_archlinux_mirror contains the resolved IP address from the nslookup command (line 18), but with the protocol prefix now included in archlinux_mirror, the nslookup will fail. This could cause the archiso_http_srv parameter to receive an unresolved hostname with protocol prefix in static IP scenarios, potentially breaking the boot process.

Suggested change
set params archiso_http_srv=${real_archlinux_mirror}/${archlinux_base_dir}/iso/${arch_version}/ archisobasedir=arch cms_verify=y ${ipparam} net.ifnames=0 {{ kernel_params }}
set params archiso_http_srv=${archlinux_mirror}/${archlinux_base_dir}/iso/${arch_version}/ archisobasedir=arch cms_verify=y ${ipparam} net.ifnames=0 {{ kernel_params }}

Copilot uses AI. Check for mistakes.
kernel ${archlinux_mirror}/${dir}/${os_arch}/vmlinuz-linux ${params}
initrd ${archlinux_mirror}/${dir}/${os_arch}/initramfs-linux.img
echo
echo MD5sums:
md5sum vmlinuz-linux initramfs-linux.img
Expand Down
Loading