Fix ESM parse error for isbinaryfile mock in tests#133
Merged
Conversation
jest.mock('isbinaryfile') without a factory still attempts to parse the
real ESM module for auto-mocking. Provide an explicit factory function
so Jest never loads the real module.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The change correctly updates the Files Reviewed (1 file)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jest.mock('isbinaryfile')without a factory still attempts to parse the real ESM-only module to auto-generate the mock, causing aSyntaxError: Cannot use import statement outside a modulefailure() => ({ isBinaryFile: jest.fn() })so Jest never loads the real moduleFollows up on #132 which addressed this for CI but the fix didn't fully prevent the ESM parse on all environments.