Skip to content

Add Extreme Networks 5320-48P-8XE-FabricEngine device type#3794

Open
0lini wants to merge 9 commits intonetbox-community:masterfrom
MPG-MMPS:master
Open

Add Extreme Networks 5320-48P-8XE-FabricEngine device type#3794
0lini wants to merge 9 commits intonetbox-community:masterfrom
MPG-MMPS:master

Conversation

@0lini
Copy link
Copy Markdown

@0lini 0lini commented Dec 12, 2025

This PR adds the Extreme Networks Switch 5320-48P-8XE with the Fabric Engine OS. I modeled SFP-Ports as module bays aswell, please tell me if this is an issue.

Copilot AI review requested due to automatic review settings December 12, 2025 11:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new device type definition for the Extreme Networks 5320-48P-8XE switch running Fabric Engine OS. This is a variant of the existing 5320-48P-8XE device type that accounts for the specific port behavior and interface naming conventions when running Fabric Engine instead of Switch Engine. The device is a 1U 48-port PoE+ switch with 8 additional 10GbE SFP+ uplink ports.

Key changes:

  • New device type file for Fabric Engine OS variant with different port configuration
  • Uses 1/X interface naming pattern instead of simple X pattern used in Switch Engine variant
  • Implements module bays for SFP+ ports (49-56) instead of interfaces, with some ports marked as blocked in Fabric Engine

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@0lini 0lini force-pushed the master branch 2 times, most recently from 0f21e02 to bab5b6e Compare December 15, 2025 08:30
@0lini 0lini force-pushed the master branch 2 times, most recently from 26bf297 to b857dc0 Compare December 15, 2025 08:35
@danner26
Copy link
Copy Markdown
Member

Hello, thank you for contributing. Please resolve all failed test cases before marking this PR as ready to review. Thank you

@danner26 danner26 marked this pull request as draft January 19, 2026 14:36
@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Jan 19, 2026
@0lini 0lini marked this pull request as ready for review January 19, 2026 19:10
@0lini
Copy link
Copy Markdown
Author

0lini commented Jan 19, 2026

Hello, thank you for contributing. Please resolve all failed test cases before marking this PR as ready to review. Thank you

Everything seems to be ready now. I would love some feedback on the SFP module stuff. Should the SFP module bays be called "SFP 1", "SFP 2", and so on?

@aaronaxvig
Copy link
Copy Markdown
Contributor

I think it would be useful to have SFP+ in the module bay name. SFP+ 1, SFP+ 2, etc. At least until there is some provision for documenting module types (vague ModuleTypeProfile capabilities notwithstanding...).

@aaronaxvig
Copy link
Copy Markdown
Contributor

You could duplicate the images with the FabricEngine name as well. Then some theoretical importing tool would grab them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: revisions needed This issue requires additional information to be actionable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants