Closes #296: Update greetings workflow for first-interaction v3 #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Greetings workflow to use the v3 input names and limit triggers to the `opened` event for issues and pull requests. Switch the greeting texts to multi-line blocks for readability. Fixes netbox-community#296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Fixes #296
New Behavior
This updates the Greetings GitHub Action to:
actions/first-interaction@v3input names (repo_token,issue_message,pr_message)issues.openedandpull_request.opened(instead of all events)Contrast to Current Behavior
Previously the workflow used the older input syntax and broader triggers, which caused the job to fail and/or run more often than necessary. With this change, the greeting runs reliably and only when a new issue/PR is opened.
Discussion: Benefits and Drawbacks
Benefits: restores the broken greeting workflow, reduces unnecessary runs, and makes the messages easier to edit.
Drawbacks: greetings will only be posted when an issue/PR is first opened (no change on other events).
This is CI-only and does not affect the NetBox ACL plugin code or runtime behavior.
Changes to the Documentation
None.
Proposed Release Note Entry
Fix Greetings GitHub Actions workflow for
actions/first-interaction@v3.Double Check
or in a linked issue.
devbranch.