13891 fix primary ip assignment if assigning ip

arthanson · jeremystretch · commit 685ac5f57127 · 2023-09-26T08:56:35.000-04:00
diff --git a/netbox/ipam/forms/model_forms.py b/netbox/ipam/forms/model_forms.py
@@ -354,7 +354,7 @@ def clean(self):
             })
         elif selected_objects:
             assigned_object = self.cleaned_data[selected_objects[0]]
-            if self.instance.pk and self.cleaned_data['primary_for_parent'] and assigned_object != self.instance.assigned_object:
+            if self.instance.pk and self.instance.assigned_object and self.cleaned_data['primary_for_parent'] and assigned_object != self.instance.assigned_object:
                 raise ValidationError(
                     _("Cannot reassign IP address while it is designated as the primary IP for the parent object")
                 )

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ def clean(self):`
`354`	`354`	`})`
`355`	`355`	`elif selected_objects:`
`356`	`356`	`assigned_object = self.cleaned_data[selected_objects[0]]`
`357`		`- if self.instance.pk and self.cleaned_data['primary_for_parent'] and assigned_object != self.instance.assigned_object:`
	`357`	`+ if self.instance.pk and self.instance.assigned_object and self.cleaned_data['primary_for_parent'] and assigned_object != self.instance.assigned_object:`
`358`	`358`	`raise ValidationError(`
`359`	`359`	`_("Cannot reassign IP address while it is designated as the primary IP for the parent object")`
`360`	`360`	`)`