Skip to content

Conversation

@arthanson
Copy link
Collaborator

@arthanson arthanson commented Dec 19, 2025

Fixes: #700

This looks big and scary, but most of the changes should be easy to review / understand.

The original bug is ObjectChanges moved to core, but there was no core and other objects live in there. Did an audit of other fields / objects missing and implemented those. There were also missing tests for most of the APIs so added tests for the base tests and integration tests, the base tests need fixtures as well. Then all the tests were replicating a base class so consolidated these into a common base class to make it DRY. Summary:

  • most changes are in tests tests/fixtures and tests/integration - these are fairly boilerplate following the existing tests.
  • the "real" changes are all in models/ adding record-types to fields (mostly JsonField) and adding the missing / moved core APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ObjectChanges moved to core module in netbox 4.1

3 participants