-
Notifications
You must be signed in to change notification settings - Fork 187
DRAFT: 700 core api #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
arthanson
wants to merge
26
commits into
master
Choose a base branch
from
700-core-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DRAFT: 700 core api #727
+3,359
−449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetBox requires passwords to have at least one uppercase letter. Updated test passwords from 'testpassword123' to 'TestPassword123' in user and token integration tests. Also added pytest.ini to configure pytest to ignore manual_tests/ directory and only run tests from tests/ directory. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #700
This looks big and scary, but most of the changes should be easy to review / understand.
The original bug is ObjectChanges moved to core, but there was no core and other objects live in there. Did an audit of other fields / objects missing and implemented those. There were also missing tests for most of the APIs so added tests for the base tests and integration tests, the base tests need fixtures as well. Then all the tests were replicating a base class so consolidated these into a common base class to make it DRY. Summary: