chore: improve logging version for each backend #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoparente
requested review from
MicahParks,
jajeffries and
mfiedorowicz
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes readiness logging across multiple agent backends by using a consistent log message format and a unified structured logging key (version) for backend version reporting.
Changes:
- Replaced backend-specific version keys (e.g.,
worker_version,snmp_discovery_version) with a single key:version. - Normalized the readiness “got version” log line formatting across the updated backends.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agent/backend/worker/worker.go | Uses version as the structured log key for readiness version logging. |
| agent/backend/snmpdiscovery/snmp_discovery.go | Uses version as the structured log key for readiness version logging. |
| agent/backend/pktvisor/pktvisor.go | Uses version as the structured log key for readiness version logging. |
| agent/backend/opentelemetryinfinity/opentelemetry_infinity.go | Uses version as the structured log key for readiness version logging. |
| agent/backend/networkdiscovery/network_discovery.go | Uses version as the structured log key for readiness version logging. |
| agent/backend/devicediscovery/device_discovery.go | Uses version as the structured log key for readiness version logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Go test coverage
Total coverage: 60.1% |
manrodrigues
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the logging of readiness messages across several backend components by unifying the log message format and the key used for version information. Instead of using different keys for each backend (e.g.,
worker_version,snmp_discovery_version), all readiness logs now use the keyversion. This makes log parsing and monitoring more consistent and easier to maintain.Logging consistency improvements:
device_discovery.goto use"version"as the key instead of"device_discovery_version".network_discovery.goto use"version"as the key instead of"network_discovery_version".opentelemetry_infinity.goto use"version"as the key instead of"opentelemetry_infinity_version".pktvisor.goto use"version"as the key instead of"pktvisor_version".snmp_discovery.goto use"version"as the key instead of"snmp_discovery_version".worker.goto use"version"as the key instead of"worker_version".