fix: new user-domain-changed event format#626
Open
DavidePrincipi wants to merge 1 commit intomainfrom
Open
Conversation
From Core 3.16+ the event carries multiple domains in a single event. Check if our user domain is in the event "domains" list.
|
ℹ️ API content change detected: No structural change, nothing to display.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the event handler to support the new event format introduced in Core 3.16+, where the user-domain-changed event can carry multiple domains in a single event payload using a domains list instead of a single domain field.
- Updated the event handler logic to check if the user domain is in the event's
domainslist - Updated minimum core version requirement to 3.16.0-0
- Improved consistency by extracting
USER_DOMAINinto a variable
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| imageroot/events/user-domain-changed/20configure_ldap | Updated to handle new multi-domain event format by checking if the user domain is in the domains list |
| Containerfile | Bumped minimum core version to 3.16.0-0 to reflect new event format requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Amygos
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Core 3.16+ the event carries multiple domains in a single event. Check if our user domain is in the event "domains" list.
The old "domain" attribute is still present in the event payload for backward compatibility.
Refs NethServer/dev#7747
Wants NethServer/ns8-core#997 NethServer/ns8-ldapproxy#24