Skip to content

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Nov 19, 2024

This is a complement to #223 looking to provide meaningful error message when @netlify/angular-runtime is not installed or is too old for it to work with angular@19 SSR handling

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit a332b6e
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/673cc4fe1200280008a1fd42
😎 Deploy Preview https://deploy-preview-226--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 19, 2024
Copy link
Contributor

@mrstork mrstork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@pieh pieh marked this pull request as ready for review November 20, 2024 08:04
@pieh pieh requested a review from a team as a code owner November 20, 2024 08:04
@pieh pieh merged commit ce7ce06 into main Nov 20, 2024
17 checks passed
@pieh pieh deleted the fix/add-error-message-when-no-runtime branch November 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants