fix(types): fix incompatible redirects types
#6165
Draft
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `netlify.toml` type marks the redirect `.query` values as optional but the (more or less) parsed result does not. This leads to some type errors downstream in Netlify CLI. This makes them compatible by marking them both as required. See https://github.com/netlify/build/blob/1b9f2f40de7ded6285e9b7c08a1adb43550a0ccf/packages /build-info/src/settings/netlify-toml.ts#L303-L305
serhalp
changed the title
redirects types
This is incompatible with types elsewhere, so not worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
netlify.tomltype marks the redirect.queryvalues as optional but the (more or less) parsed result does not. This leads to some type errors downstream in Netlify CLI.This makes them compatible by marking them both as required.
See
build/packages/build-info/src/settings/netlify-toml.ts
Lines 303 to 305 in 1b9f2f4