Skip to content

chore: remove dynamic import handler flag from feature flags #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −16
Open

chore: remove dynamic import handler flag from feature flags #6308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/zip-it-and-ship-it/src/feature_flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ export const defaultFlags = {

// Adds the `___netlify-telemetry.mjs` file to the function bundle.
zisi_add_instrumentation_loader: true,

// Dynamically import the function handler.
zisi_dynamic_import_function_handler_entry_point: false,
} as const

export type FeatureFlags = Partial<Record<keyof typeof defaultFlags, boolean>>
Expand Down
15 changes: 2 additions & 13 deletions packages/zip-it-and-ship-it/src/runtimes/node/utils/entry_file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,26 +45,15 @@ export const kebabCase = (input: string): string =>
const getEntryFileContents = (
mainPath: string,
moduleFormat: string,
featureFlags: FeatureFlags,
_featureFlags: FeatureFlags,
runtimeAPIVersion: number,
) => {
const importPath = `.${mainPath.startsWith('/') ? mainPath : `/${mainPath}`}`

if (runtimeAPIVersion === 2) {
if (featureFlags.zisi_dynamic_import_function_handler_entry_point) {
return [
`import * as bootstrap from './${BOOTSTRAP_FILE_NAME}'`,
`export const handler = bootstrap.getLambdaHandler('${importPath}')`,
].join(';')
}
return [
`import * as bootstrap from './${BOOTSTRAP_FILE_NAME}'`,
`import * as func from '${importPath}'`,

// See https://esbuild.github.io/content-types/#default-interop.
'const funcModule = typeof func.default === "function" ? func : func.default',

`export const handler = bootstrap.getLambdaHandler(funcModule)`,
`export const handler = bootstrap.getLambdaHandler('${importPath}')`,
].join(';')
}

Expand Down
Loading