Skip to content

chore: use edge functions bootstrap package in tests #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025
Merged

chore: use edge functions bootstrap package in tests #6588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee9564
chore: use edge functions bootstrap package in tests
eduardoboucas Jul 30, 2025
fff3d79
fix: update `module` setting
eduardoboucas Jul 30, 2025
5a588de
refactor: revert tsconfig changes
eduardoboucas Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions packages/edge-bundler/node/server/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ import { readFile } from 'fs/promises'
import { join } from 'path'
import process from 'process'

// @ts-expect-error TypeScript is complaining about the values for the `module`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better-ajv-errors started erroring, for instance.

// and `moduleResolution` configuration properties, but changing those to more
// modern values causes other packages to fail. Leaving this for now, but we
// should have a proper fix for this.
import { getURL as getBootstrapURL } from '@netlify/edge-functions-bootstrap/version'
import getPort from 'get-port'
import tmp from 'tmp-promise'
import { v4 as uuidv4 } from 'uuid'
Expand All @@ -22,7 +27,7 @@ test('Starts a server and serves requests for edge functions', async () => {
const servePath = join(basePath, '.netlify', 'edge-functions-serve')
const server = await serve({
basePath,
bootstrapURL: 'https://edge.netlify.com/bootstrap/index-combined.ts',
bootstrapURL: await getBootstrapURL(),
port,
servePath,
})
Expand Down Expand Up @@ -119,7 +124,7 @@ test('Serves edge functions in a monorepo setup', async () => {
const servePath = join(basePath, '.netlify', 'edge-functions-serve')
const server = await serve({
basePath,
bootstrapURL: 'https://edge.netlify.com/bootstrap/index-combined.ts',
bootstrapURL: await getBootstrapURL(),
port,
rootPath,
servePath,
Expand Down
1 change: 1 addition & 0 deletions packages/edge-bundler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"test": "test/node"
},
"devDependencies": {
"@netlify/edge-functions-bootstrap": "^2.14.0",
"@types/node": "^18.19.111",
"@types/semver": "^7.3.9",
"@types/uuid": "^10.0.0",
Expand Down
Loading