fix(types): improve type safety in create-stream-promise util #7855
Conversation
This commit improves the type safety of the `create-stream-promise` utility by: - Correctly typing the `data` variable as `Buffer[]` to ensure type-safe usage with `Buffer.concat`. - Typing the `timeoutId` as `NodeJS.Timeout | null` to remove ambiguity. - Explicitly typing the `chunk` parameter as `Buffer`. - Generalizing the `stream` parameter to `Readable` for wider use. - Removing now-obsolete `@ts-expect-error` comments.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
serhalp
changed the title
create-stream-promise
This change improves the type safety of the
create-stream-promiseutility insrc/utils/create-stream-promise.tsby adding explicit types for thestream,data, andtimeoutIdvariables. It also removes the now-obsolete@ts-expect-errorcomments.PR created automatically by Jules for task 7444641562731141912 started by @serhalp