fix: stop zipping tar files #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go client has some legacy logic for handling non-ZIP files and creating a ZIP archive around them. So anything that isn't a
.zipgets that treatment.This is problematic when we add support for other archive formats, which is the case with the
.tgzfiles used by Play.So while this logic is mostly legacy at this point — since I think even Go functions are now zipped by zip-it-and-ship-it — I'm keeping it and just adding a special case for tar files. When we detect them, leave them alone and don't wrap them in a ZIP.