Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1127

/assign jotak

Fix issue where several metrics filters targetting the same key would
not be ORed, which should be an expected behaviour.

This is necessary for filters such as "SubnetLabel is absent OR starts
with EXT-", which is a pattern that should become pretty common.
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 21, 2025

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NETOBSERV-2438

In response to this:

This is an automated cherry-pick of #1127

/assign jotak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2025

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.87%. Comparing base (8a01aec) to head (65def73).
⚠️ Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #1136      +/-   ##
================================================
+ Coverage         66.77%   66.87%   +0.10%     
================================================
  Files               121      121              
  Lines              7572     7584      +12     
================================================
+ Hits               5056     5072      +16     
+ Misses             2184     2181       -3     
+ Partials            332      331       -1     
Flag Coverage Δ
unittests 66.87% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/pipeline/encode/metrics/filtering.go 100.00% <100.00%> (ø)
pkg/pipeline/encode/metrics/preprocess.go 93.61% <100.00%> (+4.48%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak merged commit 25fbe06 into netobserv:release-1.10 Nov 21, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants