Bumped golangci-lint from v1.56.2 to v1.61.0

[PMaynard]

Description

Bumped golangci-lint from v1.56.2 to v1.61.0

Dependencies

n/a

Checklist

Sorry, just fixing local build errors.

[openshift-ci]

Hi @PMaynard. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 64.38356% with 26 lines in your changes missing coverage. Please review.

Project coverage is 64.36%. Comparing base (63d2a39) to head (9809d42).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/pipeline/write/write_ipfix.go	0.00%	11 Missing ⚠️
pkg/pipeline/transform/transform_generic.go	30.76%	9 Missing ⚠️
pkg/pipeline/extract/aggregate/aggregate.go	82.60%	2 Missing and 2 partials ⚠️
pkg/pipeline/transform/kubernetes/enrich.go	50.00%	1 Missing ⚠️
pkg/test/utils.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   64.38%   64.36%   -0.03%     
==========================================
  Files         108      108              
  Lines        8301     8301              
==========================================
- Hits         5345     5343       -2     
- Misses       2638     2639       +1     
- Partials      318      319       +1     

Flag	Coverage Δ
unittests	64.36% <64.38%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cmd/apitodoc/main.go	100.00% <100.00%> (ø)
pkg/confgen/confgen.go	50.36% <ø> (ø)
pkg/confgen/doc.go	96.20% <100.00%> (ø)
pkg/confgen/grafana_jsonnet.go	54.21% <100.00%> (ø)
pkg/pipeline/encode/encode_prom.go	49.54% <100.00%> (ø)
pkg/pipeline/encode/encode_prom_metric.go	79.78% <ø> (ø)
pkg/pipeline/encode/metrics_common.go	80.89% <100.00%> (ø)
pkg/pipeline/encode/opentelemetry/opentelemetry.go	47.92% <100.00%> (ø)
pkg/pipeline/extract/aggregate/aggregates.go	91.07% <100.00%> (-0.16%)	⬇️
pkg/pipeline/extract/timebased/filters.go	81.73% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

[jotak]

Thanks @PMaynard
.. but this probably won't do what you expect, this is a generated file that you changed

[jotak]

this is an auto-generated file (see header), it's not how it should be updated.
TBH I'm not a fan of "bingo", the tool used for bin dependencies here (I find it a bit opaque for the simple job we're asking .. and I always forget how it works :-/ ) .. let me see if I can quickly remove that and align this repo we our other ones

[PMaynard]

ops, my bad. Good choice removing bingo.

[jotak]

now there's a bunch of lint errors to fix 😅

[jotak]

I'm working on fixing the issues, will update soon

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

/lgtm