NETOBSERV-2030: deploy on master nodes

[jpinsonneau]

Description

Tolerations were missing to deploy on master nodes.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:64e36ce

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=64e36ce make commands

or download the updated commands.

[memodi]

/label qe-approved

[jpinsonneau]

@jotak / @msherif1234 can I please get a quick review here as this is trivial change with huge impact ?
Thx

[jotak]

what does it mean to have just operator: Exists without a key?

[jotak]

(btw, how does that work in the operator? I never realized we did anything special to have the agents on the master nodes, do we?)

[jpinsonneau]

That's exactly how it's done on the operator actually:
https://github.com/netobserv/network-observability-operator/blob/1aaeb6b3c0719c9ef73667daa3a04df0d69fd3ba/pkg/helper/flowcollector.go#L227

It's a trick to skip taints:

// Operator represents a key's relationship to the value.
// Valid operators are Exists and Equal. Defaults to Equal.
// Exists is equivalent to wildcard for value, so that a pod can
// tolerate all taints of a particular category.
// +optional

[jotak]

Ok, I learned something, thanks! :-)
Wondering if we should make it an option? Like, if we start capturing pcap on master nodes, wouldn't be a higher risk to make the whole cluster unstable?

[jpinsonneau]

You can use the --node-selector option to filter out which node to target. I feel it's good enough.
#146 is adding a example with it

[openshift-ci-robot]

@jpinsonneau: This pull request references NETOBSERV-2030 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

Tolerations were missing to deploy on master nodes.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment