Skip to content

NETOBSERV-2016 refactor display options#144

Merged
jpinsonneau merged 1 commit intonetobserv:mainfrom
jpinsonneau:2016
Jan 20, 2025
Merged

NETOBSERV-2016 refactor display options#144
jpinsonneau merged 1 commit intonetobserv:mainfrom
jpinsonneau:2016

Conversation

@jpinsonneau
Copy link
Member

@jpinsonneau jpinsonneau commented Jan 7, 2025

Description

Refactor display options to improve code quality. Also took the chance to add namespace enrichment view

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2025

New changes are detected. LGTM label has been removed.

@jpinsonneau
Copy link
Member Author

rebased without changes

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Member Author

Report coverage is failing to push and konflux is timing out 🥳
Is it good to squash and merge @jotak ?

@jotak
Copy link
Member

jotak commented Jan 20, 2025

oh, yes. In other repos we are less strict with codecov uploads failing

@jpinsonneau jpinsonneau merged commit 9755653 into netobserv:main Jan 20, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants