Skip to content

[Backport] NETOBSERV-2021: Improve UX#159

Merged
openshift-merge-bot[bot] merged 1 commit intonetobserv:release-1.8from
jpinsonneau:2021_backport
Jan 30, 2025
Merged

[Backport] NETOBSERV-2021: Improve UX#159
openshift-merge-bot[bot] merged 1 commit intonetobserv:release-1.8from
jpinsonneau:2021_backport

Conversation

@jpinsonneau
Copy link
Member

Backport of #146

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 30, 2025

@jpinsonneau: This pull request references NETOBSERV-2021 which is a valid jira issue.

Details

In response to this:

Backport of #146

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jpinsonneau jpinsonneau requested a review from jotak January 30, 2025 16:20
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.8@6391328). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/map_format.go 66.66% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.8     #159   +/-   ##
==============================================
  Coverage               ?   23.53%           
==============================================
  Files                  ?       11           
  Lines                  ?     1330           
  Branches               ?        0           
==============================================
  Hits                   ?      313           
  Misses                 ?     1000           
  Partials               ?       17           
Flag Coverage Δ
unittests 23.53% <73.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/flow_capture.go 31.78% <100.00%> (ø)
cmd/options.go 25.00% <ø> (ø)
cmd/map_format.go 25.27% <66.66%> (ø)

@msherif1234
Copy link
Contributor

/lgtm

@msherif1234
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f5ed628 into netobserv:release-1.8 Jan 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants