Skip to content

[Backport] NETOBSERV-2107 Disable worload metrics#175

Closed
jpinsonneau wants to merge 1 commit intonetobserv:release-1.8from
jpinsonneau:disable_worload_metrics_backport
Closed

[Backport] NETOBSERV-2107 Disable worload metrics#175
jpinsonneau wants to merge 1 commit intonetobserv:release-1.8from
jpinsonneau:disable_worload_metrics_backport

Conversation

@jpinsonneau
Copy link
Member

Backport of #174

@jpinsonneau jpinsonneau changed the base branch from main to release-1.8 February 13, 2025 15:22
@jpinsonneau jpinsonneau changed the title NETOBSERV-2107 Disable_worload_metrics_backport [Backport] NETOBSERV-2107 Disable worload metrics Feb 13, 2025
@jpinsonneau jpinsonneau requested review from jotak and memodi February 13, 2025 15:24
@jpinsonneau
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2025

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 932a7ad link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment on lines -354 to -378
"SrcK8S_Namespace",
"DstK8S_Namespace",
"K8S_FlowLayer",
"SrcSubnetLabel",
"DstSubnetLabel",
"SrcK8S_OwnerName",
"DstK8S_OwnerName",
"SrcK8S_OwnerType",
"DstK8S_OwnerType",
"SrcK8S_Type",
"DstK8S_Type",
"DnsFlagsResponseCode"
],
"remap": null,
"buckets": [
0.005,
0.01,
0.02,
0.03,
0.04,
0.05,
0.075,
0.1,
0.25,
1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpinsonneau would reducing labels and buckets help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will help a bit but you will still face the same issue after some time 😸
The safest way is to remove these

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, sounds good. Once you rebase, I'll give it a go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 it's already based on 1.8 branch 😮

@jpinsonneau jpinsonneau reopened this Feb 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Member Author

/retest

@jpinsonneau
Copy link
Member Author

Reopened in #176 since that PR pointed to main and messed up with the jobs 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants