Skip to content

NETOBSERV-2123: remove 1.8 unsupported features from cli #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msherif1234 wants to merge 1 commit into from
Closed

NETOBSERV-2123: remove 1.8 unsupported features from cli #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions scripts/functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,32 +674,6 @@ function check_args_and_apply() {
exit 1
fi
;;
*enable_network_events) # Enable Network events monitoring
if [[ "$3" == "flows" || "$3" == "metrics" ]]; then
defaultValue "true"
if [[ "$value" == "true" || "$value" == "false" ]]; then
edit_manifest "network_events_enable" "$value" "$2"
else
echo "invalid value for --enable_network_events"
fi
else
echo "--enable_network_events is invalid option for packets"
exit 1
fi
;;
*enable_udn_mapping) # Enable User Defined Network mapping
if [[ "$3" == "flows" || "$3" == "metrics" ]]; then
defaultValue "true"
if [[ "$value" == "true" || "$value" == "false" ]]; then
edit_manifest "udn_enable" "$value" "$2"
else
echo "invalid value for --enable_udn_mapping"
fi
else
echo "--enable_udn_mapping is invalid option for packets"
exit 1
fi
;;
*enable_pkt_translation) # Enable Packet translation
if [[ "$3" == "flows" || "$3" == "metrics" ]]; then
defaultValue "true"
Expand All @@ -719,8 +693,6 @@ function check_args_and_apply() {
edit_manifest "pkt_drop_enable" "$value" "$2"
edit_manifest "dns_enable" "$value" "$2"
edit_manifest "rtt_enable" "$value" "$2"
edit_manifest "network_events_enable" "$value" "$2"
edit_manifest "udn_enable" "$value" "$2"
edit_manifest "pkt_xlat_enable" "$value" "$2"
else
echo "invalid value for --enable_all"
Expand Down
2 changes: 0 additions & 2 deletions scripts/help.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,9 @@ function version {
function features_usage {
echo " --enable_all: enable all eBPF features (default: false)"
echo " --enable_dns: enable DNS tracking (default: false)"
echo " --enable_network_events: enable network events monitoring (default: false)"
echo " --enable_pkt_translation: enable packet translation (default: false)"
echo " --enable_pkt_drop: enable packet drop (default: false)"
echo " --enable_rtt: enable RTT tracking (default: false)"
echo " --enable_udn_mapping: enable User Defined Network mapping (default: false)"
echo " --get-subnets: get subnets information (default: false)"
}

Expand Down