Add missing description label to downstream containerfile#193
Merged
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom Feb 27, 2025
Merged
Add missing description label to downstream containerfile#193openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
Conversation
6599843 to
b3cd155
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 23.53% 23.53%
=======================================
Files 11 11
Lines 1330 1330
=======================================
Hits 313 313
Misses 1000 1000
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. |
b3cd155 to
3d7faa6
Compare
jotak
reviewed
Feb 27, 2025
Dockerfile.downstream
Outdated
| LABEL io.openshift.tags="network-observability-cli" | ||
| LABEL upstream-vcs-type="git" | ||
| LABEL upstream-vcs-ref=$COMMIT | ||
| LABEL description="network-observability-cli is a lightweight Flow, Packet and Metrics visualization tool." |
Member
There was a problem hiding this comment.
Suggested change
| LABEL description="network-observability-cli is a lightweight Flow, Packet and Metrics visualization tool." | |
| LABEL description="Network Observability CLI is a lightweight Flow, Packet and Metrics visualization tool for on-demand monitoring." |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
3d7faa6 to
cebd8d3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
build oc and kubectl from src
add description label
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.