Skip to content

NETOBSERV-2114: automate krew releases#195

Merged
jotak merged 1 commit intonetobserv:mainfrom
jpinsonneau:2114
Mar 24, 2025
Merged

NETOBSERV-2114: automate krew releases#195
jotak merged 1 commit intonetobserv:mainfrom
jpinsonneau:2114

Conversation

@jpinsonneau
Copy link
Member

Description

Following https://github.com/rajatjindal/krew-release-bot instructions
Relying on https://github.com/TriPSs/conventional-changelog-action for changelog generation

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.53%. Comparing base (ee29268) to head (b6c1597).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   23.53%   23.53%           
=======================================
  Files          11       11           
  Lines        1330     1330           
=======================================
  Hits          313      313           
  Misses       1000     1000           
  Partials       17       17           
Flag Coverage Δ
unittests 23.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak changed the title NETOBSERV-2114 automate krew releases NETOBSERV-2114: automate krew releases Mar 3, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 3, 2025

@jpinsonneau: This pull request references NETOBSERV-2114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

Following https://github.com/rajatjindal/krew-release-bot instructions
Relying on https://github.com/TriPSs/conventional-changelog-action for changelog generation

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you do a test / have an example to show of the generated changelog ?

@jpinsonneau
Copy link
Member Author

did you do a test / have an example to show of the generated changelog ?

It should look like this: https://github.com/TriPSs/conventional-changelog-action/releases/tag/v6.0.0

But I didn't tested it. Is there a way to test all the changes at once appart from doing a release ?

@jotak
Copy link
Member

jotak commented Mar 3, 2025

We should be able to test as a "on push" workflow, on branch workflow-test. It can be used as a workflow playground. We can also include the actions/create-release@v1 action on-push temporarily, and delete it manually after

I mean, we would just include:

      - name: conventional Changelog Action
        id: changelog
        uses: TriPSs/conventional-changelog-action@v6
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
      - name: create github release
        uses: actions/create-release@v1
        id: create_release
        with:
          draft: false
          prerelease: false
          release_name: ${{ env.tag }}
          tag_name: ${{ env.tag }}
          body: ${{ steps.changelog.outputs.clean_changelog }}
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

without the krew-index release

@jotak
Copy link
Member

jotak commented Mar 24, 2025

I'll merge it and try the release.

@jotak jotak merged commit 2f27a55 into netobserv:main Mar 24, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants